Where this goes wrong
Dividing by the solvent alone. 12.0 g of NaCl in 138.0 g of water: 12.0 ÷ 138.0 × 100 = 8.70%. The salt is part of the solution: 12.0 ÷ 150.0 × 100 = 8.00%. Molarity also divides by the solution, never by the water poured in.
Dividing by milliliters. 0.344 mol KNO₃ ÷ 225 mL = 0.00153, in mol/mL, 1000 times too small. Molarity is per liter: 0.344 ÷ 0.225 L = 1.53 M.
Flipping the dilution ratio. 750.0 mL × (2.50 ÷ 3.00) = 625 mL, less liquid than the start. Diluting grows the volume: 750.0 × (3.00 ÷ 2.50) = 900. mL.
Reporting the total as the water. 900. mL is the whole diluted solution. The water added is 900. − 750.0 = 150. mL.